Problem/Motivation

The following issues show up when using php 8.4:

PHP Deprecated:  Drupal\group_content_menu\GroupContentMenuParentFormSelector::parentSelectElement(): Implicitly marking parameter $menus as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/group_content_menu/src/GroupContentMenuParentFormSelector.php on line 53

PHP Deprecated:  Drupal\group_content_menu\GroupContentMenuParentFormSelector::getMenuOptions(): Implicitly marking parameter $menu_names as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/group_content_menu/src/GroupContentMenuParentFormSelector.php on line 77

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork group_content_menu-3545902

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alecsmrekar created an issue. See original summary.

alecsmrekar opened merge request !58

alecsmrekar’s picture

alecsmrekar commented
Assigned: alecsmrekar » Unassigned
Status: Active » Needs review
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Are any of the phpstan findings in https://git.drupalcode.org/issue/group_content_menu-3545902/-/jobs/6488023 also valid for PHP 8.4 support?

alecsmrekar’s picture

alecsmrekar commented

None of these seem directly related to PHP 8.4, everything seems to be working regardless of these phpstan warnings

  • heddn committed b12c4324 on 3.0.x authored by alecsmrekar 
    feat: #3545902 PHP 8.4 compatibility issues

By: alecsmrekar
By: plach...

  • heddn committed 9e040077 on 2.0.x authored by alecsmrekar 
    feat: #3545902 PHP 8.4 compatibility issues

By: alecsmrekar
By: plach...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.