Problem/Motivation

Steps to reproduce

Create a quicktab. Add title with "&" which is displaying as "&" in frontend

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 After Patch.png48.95 KBsandeep_k
#7 Before Patch.png53.75 KBsandeep_k
#5 After.png13.38 KBtanushree gupta
#5 Before.png14.17 KBtanushree gupta
#2 Quicktab-issue.png7.96 KBpragya.shroti

Issue fork quicktabs-3545740

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pragya.shroti created an issue. See original summary.

pragya.shroti’s picture

pragya.shroti commented
Issue summary: View changes
StatusFileSize
new Quicktab-issue.png7.96 KB
tanushree gupta’s picture

tanushree gupta commented
Assigned: Unassigned » tanushree gupta

tanushree gupta opened merge request !46

tanushree gupta’s picture

tanushree gupta commented
StatusFileSize
new Before.png14.17 KB
new After.png13.38 KB

Fixed tab title encoding. “&” was showing as “&”.
We stopped pre-escaping titles and now filter the raw title with Xss::filter (allowing limited tags).
For link labels, we pass the filtered text as safe markup.
Here are screenshots attaching for reference.

tanushree gupta’s picture

tanushree gupta commented
Assigned: tanushree gupta » Unassigned
Status: Active » Needs review
sandeep_k’s picture

sandeep_k commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch.png53.75 KB
new After Patch.png48.95 KB

I tested this on Drupal version 10.3 and was able to successfully reproduce the issue. The “MR !46 mergeable” fix applied without any problems, and the issue was resolved for me. I’ve added the before-and-after results here. Marking as RTBC++.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 4.0.1 » 4.0.x-dev
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

I shored up my own comments and added a regression test so we can see it fail with tests only run and now they don't. Thanks for reporting this and sorting it everyone!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.