Problem/Motivation

After setting up the CI/CD configuration, I see a some PHPCS / PHPSTAN issues: https://git.drupalcode.org/project/machine_name/-/pipelines/592008

It'd great to fix them and have all the three green checks

Steps to reproduce

Look closely into the issues to fix: https://git.drupalcode.org/project/machine_name/-/pipelines/592008

Proposed resolution

Fix the issues

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork machine_name-3545546

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

danrod created an issue. See original summary.

ankitv18 made their first commit to this issue’s fork.

ankitv18 opened merge request !9

ankitv18’s picture

ankitv18 commented
Status: Active » Needs review

MR!9 is ready for a review.

danrod’s picture

danrod
Location Ottawa
commented

Tested it and looks ok, I'll merge this to the main branch.

danrod’s picture

danrod
Location Ottawa
commented
Status: Needs review » Reviewed & tested by the community

danrod’s picture

danrod
Location Ottawa
commented

Thanks for this @ankitv18 , merged to the main branch.

ankitv18’s picture

ankitv18 commented

Anything pending here? or can we mark this as Fixed?

danrod’s picture

danrod
Location Ottawa
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.