Problem/Motivation

During the annotation-to-attribute test metadata migration, we converted no longer supported @covers annotations to @legacy-covers.

Proposed resolution

On class level metadata, we can map @legacy-covers to #[CoversClass], #[CoversMethod], #[CoversFunction], #[CoversTrait] attributes.

In this issue target Unit, Functional, FunctionalJavascript and Build tests. In a follow up, target Kernel tests (that are not yet converted to test attributes).

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3545325-nr-bot_25wp46so.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3545325

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
Parent issue: » #3535662: [meta] Convert test metadata from annotations to attributes
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Postponed

mondrake opened merge request !13179

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Remove @legacy-covers annotations on class metadata » Remove @legacy-covers annotations on class metadata - part 1
Issue summary: View changes
Status: Postponed » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
mstrelan’s picture

mstrelan commented
Issue summary: View changes

Looked at the first two files, aren't we losing some annotations that haven't been converted yet here?

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes

#7 done, thanks!

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3545325-nr-bot_25wp46so.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review

rebased

mstrelan’s picture

mstrelan commented
Status: Needs review » Reviewed & tested by the community

Can confirm my concerns in #7 have been addressed. Have read through the MR and confirmed a one-to-one mapping of annotation to attributes here.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This looks good, nice that we can get rid of @legacy-covers again pretty easily.

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • catch committed 7dcb394c on 11.x 
    Issue #3545325 by mondrake, mstrelan: Remove @legacy-covers annotations...

catch closed merge request !13179

mondrake’s picture

mondrake
Location 🇮🇹
commented

nice that we can get rid of @legacy-covers again pretty easily

on class level, yes; on method level, it's a challenge.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.