In #3523808: Fix failing pipelines we switched all our plugins to use attributes instead of annotations, but due to test failures had to revert this for our Views row plugins (see comment #9). We should find out the actual cause for this test failure and amend it.

I think the comment in #3544047-5: Fix failing pipelines might be the key: It seems that if some dependency is not available then switching from annotation to attribute discovery will suddenly make the plugin disappear.

Issue fork search_api-3545312

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drunken monkey created an issue. See original summary.

drunken monkey opened merge request !268

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review

OK, seems it had nothing to do with discovery, actually, it’s just that the display_types property didn’t correctly default to ['normal'] in the tests for some reason, even though it works fine on the actual site.
Anyways, should be fixed in this MR.

  • drunken monkey committed 4d6b10ab on 8.x-1.x 
    [#3545312] fix: Fixed our Views row plugins to use plugin attributes....
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Great, CI agrees. Merged.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.