Problem/Motivation

Replace annotation-based test metadata with PHP attributes.

Please DO NOT change the MR here manually. The patch is automatically generated by the MR at #3446380: [no-commit] Define a Rector rule to convert test annotations to attributes.

Proposed resolution

In this issue, convert core's Kernel tests, with the exception of:

  • ...

that all require manual conversion in a follow up.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3545163-nr-bot_bcpc82cc.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3545163

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !13174

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3545163-nr-bot_bcpc82cc.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review

Bah, bot.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Changes look good to me. Didn't see any abstract classes getting touched to class level legacy-covers.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • catch committed 611ffd39 on 11.x 
    Issue #3545163 by mondrake, catch: Convert test annotations to...

catch closed merge request !13174

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

nit: looks like some of the docblock indentations are incorrect. I assume this would be fixed automatically with phpcbf?

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +Needs followup

#11 I couldn’t find any phpcs/bcf rule dealing with PHPDoc indentation, surprisingly. That also explains why the PHPCS ci job does not fail. But yeah, it looks like this is a good job for that tool.

FWIW, I could not find a coding standard on the same topic, either.

Looks like we need follow ups here, tagging.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.