Problem/Motivation

Currently, it is not possible to filter mentioned nodes by bundle.

Steps to reproduce

Proposed resolution

Allow to filter nodes by bundle through a dedicated setting.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor_mentions-3544907

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

grevil opened merge request !31

grevil’s picture

grevil commented
Status: Active » Needs review

Done, please review!

grevil’s picture

grevil commented

The query limit fixes issue #3441810: Memory size get exhausted if we try to use this module in system which has 10,000+ users is fixed here, so I don't have to bother with rebasing errors.

grevil’s picture

grevil commented
Title: Allow to filter nodes by bundle » Allow to filter nodes by bundle and improve entity query
grevil’s picture

grevil commented

All done now. Please review!

grevil’s picture

grevil commented
Priority: Normal » Major
dinazaur’s picture

dinazaur commented
Priority: Major » Minor
dinazaur’s picture

dinazaur commented
Category: Task » Feature request
grevil’s picture

grevil commented
Status: Needs review » Needs work

Hey @dinazaur, filtering by bundle and especially the provided entity query improvements are quite important as this module is unusable on large scale sites. I agree with you, that this should normally be a part of #3441810: Memory size get exhausted if we try to use this module in system which has 10,000+ users but I didn't want to handle the rebase errors.

Setting back to "Needs work" as the tests fail, sorry didn't see that.

dinazaur’s picture

dinazaur commented

> filtering by bundle and especially the provided entity query improvements are quite important as this module is unusable on large scale sites

Yes, the only issue is in #3441810: Memory size get exhausted if we try to use this module in system which has 10,000+ users. We need to fix it.

Bundle filtering is not a problem at all. There's:
1. plugin system
2. query alter tag

Developers can do whatever they want. So this is minor improvement

grevil’s picture

grevil commented
Status: Needs work » Needs review

Ok, I see, that I can not persuade you into fixing #3441810: Memory size get exhausted if we try to use this module in system which has 10,000+ users here. Therefore, I agree this being a minor improvement.

I don't like the idea of using query parameters. We need to leverage plugin system instead

Adjusted accordingly, please review!

grevil’s picture

grevil commented
Title: Allow to filter nodes by bundle and improve entity query » Allow to filter nodes by bundle
grevil’s picture

grevil commented
Assigned: Unassigned » dinazaur
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@dinazaur any additions? :)

dinazaur’s picture

dinazaur commented

I don't have time now for review. At first glance, it looks okay.

grevil’s picture

grevil commented
Assigned: dinazaur » anybody

All fixed, please review again!

grevil’s picture

grevil commented
Status: Needs review » Needs work
grevil’s picture

grevil commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » Unassigned
Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community

Great work @grevil! RTBC!

  • grevil committed 600347e0 on 3.0.x 
    [#3544907] feat: Allow to filter nodes by bundle
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.