Problem/Motivation

On 26th of August OhDear was introducing a breaking change to their API. Alongside they released version 4 of their PHP-SDK which is built from the ground up. In order for this module to stay functional we'd need to upgrade the SDK.

Plan

Create a new 3.x branch of this module where ohdear-php-skd v4 changes will be included.

1.x and 2.x releases support is going to be dropped. They are not compatible with the OhDear API anymore. Make sure to upgrade to ^3.0 once it is released.

Issue fork ohdear_integration-3544574

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

arthur_lorenz created an issue. See original summary.

useernamee made their first commit to this issue’s fork.

useernamee’s picture

useernamee commented

One endpoint is broken:

Location 	<domain>/admin/reports/ohdear/uptime

Message 	OhDear\PhpSdk\Exceptions\NotFoundException: The resource you are looking for could not be found. in OhDear\PhpSdk\OhDear->handleRequestError() (line 67 of /app/vendor/ohdearapp/ohdear-php-sdk/src/MakesHttpRequests.php).

Will update the php-sdk and re-test.

useernamee opened merge request !31

useernamee’s picture

useernamee commented
Issue summary: View changes
useernamee’s picture

useernamee commented
Status: Active » Needs review
useernamee’s picture

useernamee commented
Issue summary: View changes
useernamee’s picture

useernamee commented

I found some issues in the drush ohdear:maintenance command and they are fixed now.
I added a changelog.md to the module.
Please review.

fago’s picture

fago
Primary language German
Location Vienna
commented
Version: 2.x-dev » 3.x-dev
Status: Needs review » Reviewed & tested by the community

Thx! I reviewed all the changes and they are generally solid. I'd say we can move on with releasing this and create individual issues for everything that might pop up during testing. Also moving this to version 3.x, since this going to be released as 3.x.

I think the following should be in a change record, to ease upgrading to the new major:
- config-key change
- environment variable change (OHDEAR_SITE_ID -> OHDEAR_MONITOR_ID)

Maybe a note that dependencies changed also?

  • useernamee committed f1e6d11f on 3.x 
    [#3544574] feat: Upgrade OhDear's PHP-SDK to v4

By: useernamee
By: fago
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.