Problem/Motivation
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/tests/src/Unit/Plugin/Filter/FreelinkingTest.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
133 | WARNING | Only string literals should be passed to t() where possible
----------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/tests/src/Unit/Plugin/freelinking/NodeTest.php
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------
124 | WARNING | Unused variable $language.
128 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/tests/src/Unit/Plugin/freelinking/UserTest.php
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
128 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/tests/src/Functional/FreelinkingBrowserTestBase.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
59 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
105 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/tests/src/Functional/FreelinkingMultilingualTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/tests/src/Functional/FreelinkingFilterTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
30 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
43 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
56 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
62 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
66 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/tests/src/Functional/NodeTitleBuiltinFailoverTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
45 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/modules/freelinking_prepopulate/tests/src/Functional/FreelinkingPrepopulateTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
126 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/src/Plugin/Filter/Freelinking.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------
178 | WARNING | Unused variable $plugin_name.
190 | WARNING | Only string literals should be passed to t() where possible
-------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal9.3.0/web/modules/contrib/freelinking/src/FreelinkingManager.php
------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------
129 | WARNING | Unused variable $key.
------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | issue-fixed-3543936-2.patch | 14.49 KB | rohit rana |
Comments
Comment #2
rohit rana commentedPlease review the patch.
Comment #3
mradcliffeThanks for submitting the patch, but it did not end up making sense years ago. phpcs quality tests are passing with phpcs.xml configured for what this module needs to do in its unit tests.