Problem/Motivation

We are adding the Facebook posts block in a paragraph using the block field module. We also are hiding the full form for the block so there is nothing to override. Because of this $block_settings['override'] isn't set which provides the warning of undefined array key when accessed.

Steps to reproduce

Configure the module to load in your FB Page.

Use the Block field module to allow for a block to be placed on a entity and set the form display widget for the field to Configuration form: hidden.

Create the content with the block.

The posts are shown and the warnings appear.

Proposed resolution

Add isset() around the checks for $block_settings['override'].

Remaining tasks

Make the patch.

CommentFileSizeAuthor
#2 socialfeed-3543873-2.patch1.89 KBoheller

Issue fork socialfeed-3543873

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

oheller created an issue. See original summary.

oheller’s picture

StatusFileSize
new1.89 KB

Here's the patch adding the isset($block_settings['override']).

hemangi.gokhale’s picture

Version: 2.0.0-beta2 » 3.0.x-dev
Status: Active » Closed (outdated)

@oheller this has already been addressed in 3.0.0-alpha1. Please upgrade and give it a try. I'm closing this issue for now, but please feel free to reopen it if the problem persists. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

oheller’s picture

Status: Closed (outdated) » Needs work

@hemangigokhale, we are using php8.3.The issue still persists because the check still is looking for a variable or property that might not exist. The check needs to confirm that the $block_settings['override'] exists before any other check is done.

hemangi.gokhale’s picture

Assigned: Unassigned » hemangi.gokhale

Thank you for confirming this, @oheller. I'll work on this fix and see if I can make progress.

hemangi.gokhale’s picture

Version: 3.0.x-dev » 4.0.x-dev
Assigned: hemangi.gokhale » Unassigned
Status: Needs work » Fixed
Issue tags: +backport

@oheller, I've fixed this issue in 4.0.x, will try to backport soon to 3.0.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.