Problem/Motivation

\Drupal\l10n_server\ConnectorParseHandlerInterface::parseHandler() documents FALSE as a valid return value.

\Drupal\l10n_server\Form\ConnectorBatchConfirmParseForm::batchOperation(), however, does not account for this and unconditionally calls a method on the return value.

Steps to reproduce

If the setup is such that the parser will return FALSE (for example if \Drupal\l10n_server\Entity\Storage\L10nServerReleaseStorage::getIdsToRefresh() returns an empty set) attempt to initiate a batch parsing job from the UI. This will lead to an exception.

Proposed resolution

Account for the return value being FALSE.

Remaining tasks

User interface changes

-

API changes

-

Data model changes

-

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

Status: Active » Needs review

See #3541994: Fix CI for the CI failures.

fmb made their first commit to this issue’s fork.

fmb credited teebeecoder.

fmb’s picture

Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.