Problem/Motivation

\Drupal\l10n_server\Entity\L10nServerRelease::getCoreFromVersion() falls back to the string all if a contrib module version does not contain a core version. The fallback results in a notice being thrown, however.

Steps to reproduce

Export a PO file for a contrib module without a core version in its version.

Proposed resolution

Fix the code to no longer throw a notice.

Remaining tasks

User interface changes

-

API changes

-

Data model changes

-

Issue fork l10n_server-3543346

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tstoeckler created an issue. See original summary.

tstoeckler opened merge request !79

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review

See #3541994: Fix CI for the CI failures.

teebeecoder changed the visibility of the branch 3543346-server-release-get-core-notice to hidden.

teebeecoder changed the visibility of the branch 3543346-server-release-get-core-notice to active.

teebeecoder’s picture

teebeecoder commented
Status: Needs review » Reviewed & tested by the community

teebeecoder’s picture

teebeecoder commented
teebeecoder’s picture

teebeecoder commented
Status: Reviewed & tested by the community » Fixed
teebeecoder’s picture

teebeecoder commented
teebeecoder’s picture

teebeecoder commented

Ty @tstoeckler, good catch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.