Problem/Motivation

The Gin admin theme will be merged into Drupal Core 11.3, see #3530852: [meta] Admin theme modernisation

In preparing for that change, Gin has to remove contrib specific code, and therefore this module should incorporate those removed changes itself. Past and current versions of the Gin admin theme are not affected by this, they continue to contain that contrib specific code.

Proposed resolution

Please collect the changes from this MR and bring that code back into this module.

Comments

jurgenhaas created an issue. See original summary.

nagy.balint’s picture

nagy.balint commented

Likely easy to do since we already have chosen.claro defined, and just need to extend it with the gin specific ones.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Issue tags: +Gin merge into Core
nagy.balint’s picture

nagy.balint commented

Another question is whether we can incorporate the code while keeping compatibility with older Gin versions. Maybe the only side effect that we will have the same css twice in the system?

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

Maybe the only side effect that we will have the same css twice in the system?

Yes, I think that's correct.

The merge into core has not happened in 11.3, though, it's been postponed for 11.4. You can follow the progress at #3556948: Merging Gin as Admin theme

  • nagy.balint committed 89df63a5 on 5.0.x 
    feat: #3543185 Incorporate module specific changes that get removed from...
nagy.balint’s picture

nagy.balint commented

Committed, thank you!

nagy.balint’s picture

nagy.balint commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.