Problem/Motivation
When TFA features are enabled and the “Users optionally can enable” pathway is selected, users without TFA enabled are not redirected to the specified destination after login when a destination parameter is present in the path.
Steps to reproduce
1. Set TFA features as Active and select “Users optionally can enable” as the default pathway.
2. Log in with a user who does not have Email TFA enabled on their account.
Example: Log in with /user/login?destination=/admin/config/people/email-tfa
3. The user is not redirected to the destination path after login.
Proposed resolution
Ensure the destination parameter from the request query is reapplied when falling back to the default login process.
Issue fork email_tfa-3542974
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
lfersoy commentedI've opened a PR with the proposed changes. Please take a look when you have a chance.
Comment #4
abdulaziz zaidThanks, the fix looks good. Restoring the destination parameter solves the issue.
Comment #5
abdulaziz zaidComment #7
abdulaziz zaidComment #9
abdulaziz zaidComment #11
abdulaziz zaid