Problem/Motivation

When TFA features are enabled and the “Users optionally can enable” pathway is selected, users without TFA enabled are not redirected to the specified destination after login when a destination parameter is present in the path.

Steps to reproduce

1. Set TFA features as Active and select “Users optionally can enable” as the default pathway.
2. Log in with a user who does not have Email TFA enabled on their account.
Example: Log in with /user/login?destination=/admin/config/people/email-tfa
3. The user is not redirected to the destination path after login.

Proposed resolution

Ensure the destination parameter from the request query is reapplied when falling back to the default login process.

Issue fork email_tfa-3542974

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lfersoy created an issue. See original summary.

lfersoy’s picture

Status: Active » Needs review

I've opened a PR with the proposed changes. Please take a look when you have a chance.

abdulaziz zaid’s picture

Thanks, the fix looks good. Restoring the destination parameter solves the issue.

abdulaziz zaid’s picture

Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

abdulaziz zaid’s picture

Status: Fixed » Needs review

abdulaziz zaid’s picture

Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

abdulaziz zaid’s picture

Issue tags: +email_tfa v2.0.6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.