Problem/Motivation

Currently a mailer plugin is both a service and a plugin. The plugin part is only really used for collecting definitions. It is also currently used as a factory for creating the service, but it doesn't need to be like that.

Proposed resolution

  1. In SymfonyMailerServiceProvider instead of setting a factory, add a tag mailer_instance
  2. Change the service file to name the mailer class in the normal way
  3. Rename MailerPluginBase to ComponentMailerBase and remove the extending of PluginBase
  4. Change MailerManager to Discover the mailers by means of the tag

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork symfony_mailer-3542799

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

adamps created an issue. See original summary.

adamps opened merge request !187

adamps’s picture

adamps commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • adamps committed a76ac2d1 on 2.x 
    [#3542799] Mailer classes don't need to be plugins

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.