The changes in #3536657: New parameters introduced in MigrateExecutable class constructor to attempt backwards compatibility is inadvertently discarding any $options provided as the third argument to the constructor.
If the MigrateExecutable constructor is invoked with the old method signature (three arguments with the third as an array), the value passed to $keyValue will not be copied over to $options and will be lost.
When an array is provided as the third argument, the code is checking whether $options is already set:
if (!isset($options)) { $options = $keyValue; }
But this is problematic because $options defaults to an empty array so it will always be set. $keyValue is updated to be the KeyValueFactoryInterface and the options array passed to the constructor is lost.
Issue fork migrate_tools-3542697
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
mediabounds commentedComment #5
mediabounds commentedComment #8
heddnThanks for the fix here.