If we use in our Drupal search custom datasources, those may have no view modes so in the line https://git.drupalcode.org/project/search_api/-/blob/8.x-1.38/src/Plugin... it will throw a TypeError: Cannot access offset of type string on string
Use a custom datasource within a Search view.
Ensure that the datasource config is an array to prevent the type error.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
drunken monkeyThanks a lot for reporting this problem!
I can reproduce it: If a datasource does not support viewing items, the
SearchApiRowplugin will crash the whole page request.However, while your patch would avoid that fatal error, I think the proper solution is slightly more complex:
render(), we should explicitly check whether the datasource supports viewing items and bail early otherwise. With your suggested code, we would still call$datasource->viewItem()which would likely result in an exception or error itself.I created an MR with those fixes, please review!
Comment #5
drunken monkeyMerged.