Problem/Motivation

The office_hours_update_8013 function is defined inside the office_hours_update_8005 function.
This looks like like a typo with a `}` causing office_hours_update_8013() not to be ran.

Also add test for the update hooks.

Steps to reproduce

Proposed resolution

Move office_hours_update_8013() outside office_hours_update_8013()
Add UnitTest for office_hours_update_8001() and office_hours_update_8013()
Add KernelTest for office_hours_update_8001() and office_hours_update_8013()

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork office_hours-3542512

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

bluegeek9 opened merge request !70

bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Active » Needs review

  • johnv committed d827dd87 on 8.x-1.x 
    Issue #3542512 by bluegeek9: Add tests for office_hours_update_xxxx()...
johnv’s picture

johnv
Primary language Dutch
commented

Committed.
The issue title does not coincide with the patch contents "git commit -m 'Issue #3542512 by bluegeek9: Add tests for office_hours_update_xxxx() functions'"

bluegeek9’s picture

bluegeek9 commented
Issue summary: View changes

I update the issue with a description.

The office_hours.install has one hook_update_N() inside another hook_update_N(). I also added tests.

https://git.drupalcode.org/project/office_hours/-/merge_requests/70/diff...

  • johnv committed bd7ce15f on 8.x-1.x 
    Issue #3542512 by bluegeek9: Add Unit/KernelTest for...
johnv’s picture

johnv
Primary language Dutch
commented
Title: Inner named functions: office_hours_update_8013 defined in office_hours_update_8005 » Add Unit/KernelTests for office_hours_update_80xx functions
Issue summary: View changes

  • johnv committed c7f0a085 on 8.x-1.x 
    Issue #3542512 by bluegeek9: Remove Unit/KernelTest for deleted...
johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.