Problem/Motivation

The tests on the 8.x-1.x branch are currently failing due to minor changes in core 11.2.x:

 Token Menu Ui Content Moderation (Drupal\Tests\token\Functional\TokenMenuUiContentModeration)
     ✘ Menu ui with pending revisions
       ┐
       ├ Behat\Mink\Exception\ResponseTextException: The text "Page obskpila has been updated." was not found anywhere in the text of the current page.
       │
       │ /builds/issue/token-3541207/vendor/behat/mink/src/WebAssert.php:907
       │ /builds/issue/token-3541207/vendor/behat/mink/src/WebAssert.php:293
       │ /builds/issue/token-3541207/web/core/tests/Drupal/Tests/WebAssert.php:981
       │ /builds/issue/token-3541207/web/core/modules/menu_ui/tests/src/Functional/MenuUiContentModerationTest.php:142
       ┴
     ⚠ Menu ui with unpublished content

The error in the output is:

Drupal\Core\Entity\EntityStorageException: An existing default revision of the 'menu_link_content' entity type can not be changed to a non-default revision. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 815 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

And..

 Token Field Ui (Drupal\Tests\token\Functional\TokenFieldUi)
     ⚠ File field ui
     ⚠ Field description tokens
     ✘ Image field tokens
       ┐
       ├ Token value for [node:field_image:thumbnail:mimetype] was 'image/avif', expected value 'image/webp'.
       ├ Failed asserting that two strings are equal.                             
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'image/webp'
       ┊ +'image/avif'
       │
       │ /builds/issue/token-3539596/tests/src/Functional/TokenTestTrait.php:37
       │ /builds/issue/token-3539596/tests/src/Functional/TokenFieldUiTest.php:264
       ┴

Proposed resolution

Fix the tests.

Remaining tasks

Fix the tests.

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork token-3541207

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

damienmckenna created an issue. See original summary.

damienmckenna’s picture

Status: Active » Needs review

MR created.

damienmckenna’s picture

Issue summary: View changes
damienmckenna’s picture

Status: Needs review » Needs work

The MR fixes the issue with the thumbnail generation, but there are still errors in TokenMenuUiContentModerationTest.

damienmckenna’s picture

Issue summary: View changes

The error in the output for TokenMenuUiContentModerationTest is:

Drupal\Core\Entity\EntityStorageException: An existing default revision of the 'menu_link_content' entity type can not be changed to a non-default revision. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 815 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

berdir’s picture

There's an existing issue for that

damienmckenna’s picture

Status: Needs work » Needs review
Related issues: +#3511768: Avoid incorrect and unecessary menu_link_content entity saving

Ah yes, thank you - #3511768: Avoid incorrect and unecessary menu_link_content entity saving.

So is the thumbnail fix all that this issue needs to be responsible for?

berdir’s picture

Title: Fix tests on 8.x-1.x branch » Fix TokenFieldUiTest

Yeah.

  • berdir committed 1f3304aa on 8.x-1.x authored by damienmckenna
    [#3541207] fix: TokenFieldUiTest is broken on 11.2
    
    By: damienmckenna
    By...
berdir’s picture

Status: Needs review » Fixed

Merged.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.