Problem/Motivation

For the last dependency injection in Http data fetcher plugin, the comma is before the closing parenthesis when it should be right after

Instead of

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition): self {
    return new static(
      $configuration,
      $plugin_id,
      $plugin_definition,
      $container->get('http_client'),
      $container->get('plugin.manager.migrate_plus.authentication',)
    );
  }

We should have

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition): self {
    return new static(
      $configuration,
      $plugin_id,
      $plugin_definition,
      $container->get('http_client'),
      $container->get('plugin.manager.migrate_plus.authentication'),
    );
  }
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

macsim created an issue. See original summary.

danrod’s picture

Assigned: Unassigned » danrod

danrod’s picture

I took the liberty to create a small change for it, hope you don't mind.

Kindly review: https://git.drupalcode.org/project/migrate_plus/-/merge_requests/138

danrod’s picture

Assigned: danrod » Unassigned
Status: Active » Needs review

heddn made their first commit to this issue’s fork.

heddn’s picture

Priority: Normal » Minor
Status: Needs review » Fixed

Thanks for the fix.

  • heddn committed 6c545e55 on 6.0.x authored by danrod
    Issue #3540407 by danrod, heddn: Typo in Http datafetcher dependencies...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.