because the $params is an empty array, we should use $subject

Issue fork activitypub-3539968

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kgaut created an issue. See original summary.

kgaut opened merge request !38

kgaut’s picture

kgaut commented
Status: Active » Needs review
kgaut’s picture

kgaut commented

With the patch from the MR, the route `/.well-known/webfinger/?resource=` is now working

swentel made their first commit to this issue’s fork.

swentel’s picture

swentel commented

Sorry for the extreme delay, but I'm wondering in what context it doesn't work? There's a test so I'm surprised the original code doesn't work. WebfingerParameters::getParams() (in the webfinger module) does have a TODO line which says: "support comparison of subdomain?", so is it because of a subdomain?

If so, we should probably open an issue in the webfinger module too, however, we can commit this patch too though to get forward now that I have a couple of months time to work on the module :)

  • swentel committed cd956645 on 1.0.x authored by kgaut 
    Issue #3539968 by kgaut: the subject is empty in...
swentel’s picture

swentel commented
Status: Needs review » Fixed

merged in!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

swentel’s picture

swentel commented
Status: Fixed » Closed (fixed)