Problem/Motivation

When the sitemaps are generated and the max_execution_time is reached inside QueueWorkerDecorator::generate(). The current state is stashed in stashResults(). When the process continues the state is restored in unstashResults() but the sitemapProcessedNow is not restored correctly because it doesn't take the site variant into account correctly.

This leads to URLs ending up in the wrong sitemap.

Steps to reproduce

If you are not having URLs in the wrong sitemap you are likely just not running into the stashing mechanism. You can reduce the max_execution_time/generate_duration.

Issue fork sites_simple_sitemap-3539866

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

harlor created an issue. See original summary.

harlor opened merge request !13

harlor’s picture

harlor commented
Status: Active » Needs review
hydra’s picture

hydra commented

Huge, this is impressive.

hydra’s picture

hydra commented
Status: Needs review » Reviewed & tested by the community
hydra’s picture

hydra commented
Status: Reviewed & tested by the community » Closed (won't fix)

This should not happen anymore with the new generate approach from https://www.drupal.org/project/sites_simple_sitemap/issues/3550027

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.