Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork rest_absolute_urls-3539370

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

batigolix created an issue. See original summary.

batigolix opened merge request !4

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Active » Needs review
arjenk’s picture

arjenk commented
Status: Needs review » Reviewed & tested by the community

code looks good, pipeline passes. When tested locally with gitlab-ci-local i got a minor warning about stylelint, so perhaps consider adding SKIP_STYLELINT: 1 as there is no css.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • batigolix committed 507f50a7 on 8.x-1.x 
    feat: #3539370 Make code pass pipeline

By: batigolix
By: arjenk

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.