In "src/Plugin/views/filter/MediaDirectory.php" there needs to be a question mark in front of "array" to avoid notices under PHP 8.4:

public function init(ViewExecutable $view, DisplayPluginBase $display, ?array &$options = NULL)

CommentFileSizeAuthor
#2 3538756.patch716 bytesrgpublic

Issue fork media_directories-3538756

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rgpublic created an issue. See original summary.

rgpublic’s picture

rgpublic
Primary language German
Location Düsseldorf 🇩🇪 🇪🇺
commented
StatusFileSize
new 3538756.patch716 bytes
ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Active » Needs review

Thanks for your report. I will check when I find time.

rgpublic’s picture

rgpublic
Primary language German
Location Düsseldorf 🇩🇪 🇪🇺
commented

@ytsurk: Just a quick reminder. I'm sure you have lots of other work, but this is a 1-character change and would instantly make this module compatible with PHP 8.4, so a very good cost / benefit ratio :-) Perhaps you could squeeze that in between?

jmaties made their first commit to this issue’s fork.

jmaties opened merge request !24

rgpublic’s picture

rgpublic
Primary language German
Location Düsseldorf 🇩🇪 🇪🇺
commented

@ytsurk: Quick reminder. Could you perhaps look into this if you have a few seconds? I had to patch dozens of websites due to this single question mark missing.

aleevas’s picture

aleevas
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

@rgpublic thank you for your patch - I can confirm that it works correctly.

@ytsurk please move this patch to the trunk.

Thank you!

rgpublic’s picture

rgpublic
Primary language German
Location Düsseldorf 🇩🇪 🇪🇺
commented

@rang501: As you are listed as another maintainer... Could you perhaps take a look? It's just a single question mark that needs to be added to make this module PHP 8.4 compatible. Thank you :-)

rang501’s picture

rang501 commented
Status: Reviewed & tested by the community » Fixed

Looked fine to me. Merged into 2.2.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.