Overview

@mglaman and I discovered while debugging why content exported using https://drupal.org/project/default_content but then updated manually over time didn't behave as expected. This (along with #3538487: Don't allow passing uncollapsed inputs if using default expression) turns out to have been the reason.

In discussing this with @larowlan, he responded: I thought we had removed support for active, but will revisit. In fact my recollection was it was only briefly supported (less than a week) (it was added in #3523841: Versioned Component config entities (SDC, JS: prop_field_definitions, block: default_setting, all: slots for fallback) + component instances refer to versions ⇒ less data to store per XB field row)

Turns out this is largely true, but the lowest-level bits for it are still around in \Drupal\experience_builder\Plugin\Field\FieldType\ComponentTreeItem::setValue() 😅 Plus a lingering config schema validation todo that points to #3526703: Adopt `AtLeastOneOf` validation constraint for cardinality validation.

Proposed resolution

Completely remove support for component_version: 'active'.

User interface changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

wim leers created an issue. See original summary.

wim leers credited mglaman.

wim leers’s picture

Assigned: Unassigned » wim leers

wim leers’s picture

@larowlan and I are the two people who worked on versioned config entities. He confirmed this should be removed already, so given the test-only CI job failed as expected, the fix is trivial … pragmatically going ahead and merging 😇

  • wim leers committed 3fcb9fc8 on 1.x
    Issue #3538503 by wim leers, larowlan, mglaman: Disallow component trees...
wim leers’s picture

Status: Reviewed & tested by the community » Fixed

This does not need backporting, because this only affected content exported using https://drupal.org/project/default_content.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.