Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 3538270-1.patch683 bytesbingol@ciandt.com

Issue fork dynamic_entity_reference-3538270

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bingol@ciandt.com created an issue. See original summary.

bingol@ciandt.com’s picture

bingol@ciandt.com commented
Title: Declaration of Drupal\dynamic_entity_reference\Plugin\diff\Field\DynamicEntityReferenceFieldBuilder::build(Drupal\Core\Field\FieldItemListInterface $field_items) must be compatible with Drupal\diff\Plugin\diff\Field\EntityReferenceFieldBuilder::build(Drup » Declaration of Drupal\dynamic_entity_reference\Plugin\diff\Field\DynamicEntityReferenceFieldBuilder::build(Drupal\Core\Field\FieldItemListInterface $field_items) must be compatible with Drupal\diff\Plugin\diff\Field\EntityReferenceFieldBuilder::build
bingol@ciandt.com’s picture

bingol@ciandt.com commented
StatusFileSize
new 3538270-1.patch683 bytes

vinodhini.e made their first commit to this issue’s fork.

shubham_pareek_19’s picture

shubham_pareek_19 commented
Assigned: Unassigned » shubham_pareek_19

Working on it.

shubham_pareek_19 opened merge request !42

shubham_pareek_19’s picture

shubham_pareek_19 commented
Assigned: shubham_pareek_19 » Unassigned
Status: Active » Needs review

The changes looks good to me, thus created a MR since patches are deprecated.
Please review

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#3440375: Cut a 2.x branch

Caused by https://git.drupalcode.org/project/diff/-/blame/2.x/src/Plugin/diff/Fiel...

vinodhini.e’s picture

vinodhini.e commented

Hi, Could you please provide more details to replicate this issue?
Currently, the issue only includes the error message, and I’m unable to reproduce it on my local. Thanks.

acbramley made their first commit to this issue’s fork.

acbramley’s picture

acbramley commented
Version: 4.0.0-alpha4 » 3.x-dev
Status: Needs review » Reviewed & tested by the community

Fixed the MR against 3.x, this is a straightforward change and can be committed as is without BC issues with Diff 8.x-1.x.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Fixed

Thank you, commited and pushed to 3.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

We are getting the same error in 4.0.0-alpha4. Could you, please, reopen (I can't) and port to 4.x + a new release? I will provide a MR

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Closed (fixed) » Needs work

claudiu.cristea opened merge request !43

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Version: 3.x-dev » 4.x-dev

Porting to 4.x

claudiu.cristea changed the visibility of the branch 3538270-4.x to hidden.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

This was fixed in 4.x since https://git.drupalcode.org/project/dynamic_entity_reference/-/commit/0f3... is committed. So I ended up creating the new alpha release for 4.x

jibran changed the visibility of the branch 3538270-4.x-port to hidden.

jibran closed merge request !43

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Version: 4.x-dev » 3.x-dev
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.