Overview

This issue for addressing review feedback for code improvements from #3503412: Allow Content Author to set site's homepage from navigator and adding a new test

Proposed resolution

User interface changes

Issue fork experience_builder-3537417

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hooroomoo created an issue. See original summary.

hooroomoo opened merge request !1341

hooroomoo credited jessebaker.

hooroomoo credited larowlan.

hooroomoo credited lauriii.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented

Adding credit for the FE review feedback received in #3503412: Allow Content Author to set site's homepage from navigator that i'm addressing here

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +clean-up, +Needs tests
Related issues: +#3503412: Allow Content Author to set site's homepage from navigator
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Title: Followup for #3503412: Allow Content Author to set site's homepage from navigator » Followup for #3503412: FE code improvements and add hompage test for after publish
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: hooroomoo » Unassigned
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Per @larowlan's approval.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Followup for #3503412: FE code improvements and add hompage test for after publish » Follow-up for #3503412: FE code improvements and add homepage test for after publish
Issue tags: +maintainability

  • wim leers committed f028193b on 1.x authored by hooroomoo 
    Issue #3537417 by hooroomoo, jessebaker, larowlan, lauriii: Follow-up...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the very fast turn-around, so shortly after #3503412, @hooroomoo! 🙏

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.