Problem/Motivation

See #3504381: [meta] Convert Template Preprocess hooks to OOP equivalent

Steps to reproduce

N/A

Proposed resolution

N/A

Remaining tasks

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#9 3536742-nr-bot_tqivmueh.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3536742

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kim.pepper created an issue. See original summary.

kim.pepper opened merge request !12770

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: Convert template_preprocess_file_link() to OOP » Convert template_preprocess_file_link() and template_preprocess_file_upload_help() to OOP
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: Convert template_preprocess_file_link() and template_preprocess_file_upload_help() to OOP » Convert all template_preprocess_file_* functions to OOP
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: Convert all template_preprocess_file_* functions to OOP » Convert template_preprocess functions in file module
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Parent issue: » #3504381: [meta] Convert Template Preprocess hooks to OOP equivalent
mohit_aghera’s picture

mohit_aghera commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I did a code review today.
Feedback from @berdier and @nicxvan has been addressed.

I didn't noticed any other specific items to validate.
The deprecation test isn't required since there aren't any specific changes as such.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3536742-nr-bot_tqivmueh.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs work » Reviewed & tested by the community

This was just a reroll so leaving at RTBC

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

catch closed merge request !12770

  • catch committed 7dca1fe5 on 11.x 
    Issue #3536742 by kim.pepper, nicxvan, berdir: Convert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.