Problem/Motivation

When using the full screen feature with any dialogs they seem to be covered up, example entity embed

Steps to reproduce

Setup a ckeditor instance with entity embed and fullscreen
Create a piece of content
Go full screen
Try and click entity embed button and notice the dialog doesn't appear
Close fullscreen and see it did appear but hidden

Proposed resolution

Don't block dialog from appearing.

Remaining tasks

Agree
Implement
Review

User interface changes

API changes

Data model changes

Issue fork ckeditor5_plugin_pack-3536673

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

salmonek made their first commit to this issue’s fork.

salmonek opened merge request !26

salmonek’s picture

salmonek commented
Status: Active » Needs review

Hi Stephen,

Thank you for bringing this to our attention.
Indeed, the Drupal UI dialogs have lower z-index than fullscreen.
I've pushed a patch with added css rule to make Drupal UI dialogs visible when using fullscreen.
Works with Claro and Gin.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Works like a charm thanks!

salmonek’s picture

salmonek commented
Status: Reviewed & tested by the community » Fixed

Released in 1.4.1

jons’s picture

jons commented
Version: 1.4.0 » 1.4.1
Status: Fixed » Needs work

comment moved to separate issue

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.