Problem/Motivation

Steps to reproduce

Sticky local tsks are a wonderful module. Since the module can also be displayed in the backend or, if you prefer, in the administration area of Drupal, I would ask you to consider implementing a dark mode.
Personally, my eyes are glad that we have finally implemented a dark mode in Drupal with Gin. Now this great module comes along and adds a very thick white layer to my dark administration area. That's not very stylish; it could look better, wouldn't you agree?

Proposed resolution

Add a dark mode variant via css and ui.
Sticky local tasks in admin area with gin enabled.

Remaining tasks

  1. Think about how to implememt dark mode for Gin.
  2. create patch.

User interface changes

TBD

API changes

TBD

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joachim namyslo created an issue. See original summary.

joachim namyslo’s picture

Issue summary: View changes

jan kellermann made their first commit to this issue’s fork.

jan kellermann’s picture

Status: Active » Needs review

Then please have a look and give feedback :)

We added classes for gin and also for tonic general dark mode without gin as admin theme.

joachim namyslo’s picture

StatusFileSize
new31.52 KB

sticky local tesks after patch applied
Well, that looks much better than before.
It would be nicer, of course, if the background color of the circular icons could be adjusted when the dark mode settings are applied.
In this case, however, the icons should be inverted so that they are still clearly visible.

That would make the widget look much better in terms of design.

I also noticed that the duplicate entry task, created by ECA, does not have an icon. Here, you could consider implementing a generic icon for such cases. But that should be the subject of a separate issue.

jan kellermann’s picture

Status: Needs review » Needs work
anirudhsingh19’s picture

Assigned: Unassigned » anirudhsingh19

working on this.

anirudhsingh19’s picture

Assigned: anirudhsingh19 » Unassigned
Status: Needs work » Needs review

I have updated the circular icons so their background color now matches the theme’s primary color. I also cleaned up the MR by removing redundant code.

If the icons had been implemented as inline SVGs, we could have changed their colors according to light and dark mode, but since they’re being used via CSS background-image, that option isn’t available.

doxigo’s picture

can't we reverse the color via CSS?

anirudhsingh19’s picture

Assigned: Unassigned » anirudhsingh19

@doxigo I have explored a little and found a way to do that, working on the changes.

anirudhsingh19’s picture

Assigned: anirudhsingh19 » Unassigned
StatusFileSize
new25.16 KB
new23.99 KB

Now the icons color is also changes according to light and dark mode. Instead of using background-image property I have used mask-image property.

doxigo’s picture

Great work so far, I personally don't like the accent color used. We should do our own good looking UI instead of doing high contrast accent colors

anirudhsingh19’s picture

I have used the gin-color-primary variable here, so the color will change according to selected gin's theme accent color. I thought it would make the color match gin theme. But yes, we can use our own color too.

anirudhsingh19’s picture

StatusFileSize
new23.53 KB
new24.71 KB

Experimented with the colors. Still uses the accent colors from gin variables.

joachim namyslo’s picture

Oh I like that a lot. Thank you very much.

joachim namyslo’s picture

StatusFileSize
new16.12 MB

Final Review

joachim namyslo’s picture

Status: Needs review » Reviewed & tested by the community

Mr 14 does it. Thank you very much, again.

Respects light mode ✅
respects darkmode ✅
reflects accent color ✅

doxigo’s picture

Thanks for the work but I kinda don't like it. We need to make the option to use Gin accent color optional. I tested on a couple of projects with different accent colors and it looks just odd and doesn't go nicely in comparison with the previous UI

I'll see what I can do

doxigo’s picture

Status: Reviewed & tested by the community » Fixed
StatusFileSize
new871.39 KB

Okay, I made some changes. Now your MR changes would only load if we enabled the "Gin" as shown below:
Sticky Local Tasks Gin Accent Color Settings

Gonna do a bit more cleanup and fixes that would play nicely with this. Thanks for the work guys. Merged

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

doxigo’s picture

Also added a "Dark theme" checkbox so you can enable dark theme regardless

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.