Problem/Motivation

Part of #3488051: [meta] Post OOP hook conversion test module cleanup, convert the one preprocess and the helper function in twig_theme_test.module

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3535675-nr-bot_c5umvkac.txt2.59 KBneeds-review-queue-bot

Issue fork drupal-3535675

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berdir created an issue. See original summary.

berdir opened merge request !12708

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Moved the function to a static method, can't use a trait as it's used in a test theme, not a test module.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3535675-nr-bot_c5umvkac.txt2.59 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Fixed phpcs.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good conversion to me.

  • catch committed c2d7d294 on 11.x 
    Issue #3535675 by berdir: Remove twig_theme_test.module
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !12708

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.