Problem/Motivation

Drupal utilizes the Symfony service container, however some features such as autowiring and autoconfiguration were not leveraged in Drupal 8. Since Drupal 9.3, services can be autowired. This means that when defining a service in *.services.yml, in many cases the arguments can be automatically inferred from the typehints on constructor arguments. More information on service autowiring in Drupal can be found in the change record.

Proposed resolution

In order for other (custom) modules using services provided by this module to be autowired, aliases needs to be added for classes and non-ambiguous core interfaces (i.e. interfaces that only have a single implementation). It's not required for services of this module to use autowire: true, that would only be possible if the module only supports Drupal 9.3.0 or higher.

Issue fork geocoder-3535459

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dieterholvoet created an issue. See original summary.

dieterholvoet opened merge request !69

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review
dieterholvoet’s picture

dieterholvoet commented
Assigned: dieterholvoet » Unassigned
itamair’s picture

itamair commented

Thanks @dieterholvoet ... for providing all this.
Not yet (super) clear to me what all this is already achieving or is setting to make the module ready to achieve,
thus I will need to better go through the parent reference: https://www.drupal.org/node/3218156

But one question from now. Is it not needed the autowire: true to enable autowiring, as mentioned inside that?

dieterholvoet’s picture

dieterholvoet commented
Issue summary: View changes

It allows other (custom) modules using services provided by this module to be autowired. It's not required for this module to use autowiring, that would only be possible if the module only supports Drupal 9.3.0 or higher.

itamair’s picture

itamair commented
Status: Needs review » Reviewed & tested by the community

thanks @dieterholvoet, going to commit/merge this asap ...

itamair’s picture

itamair commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.