Problem/Motivation

Module is not compatible with php 8.4

Steps to reproduce

Throws warnings on drush cr

PHP Deprecated: Drupal\tmgmt\Entity\Job::isAuthor(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/docroot/modules/contrib/tmgmt/src/Entity/Job.php on line 584

Deprecated: Drupal\tmgmt\Entity\Job::isAuthor(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/docroot/modules/contrib/tmgmt/src/Entity/Job.php on line 584
PHP Deprecated: Drupal\tmgmt\JobInterface::isAuthor(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/docroot/modules/contrib/tmgmt/src/JobInterface.php on line 394

Deprecated: Drupal\tmgmt\JobInterface::isAuthor(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/docroot/modules/contrib/tmgmt/src/JobInterface.php on line 394

Proposed resolution

Fix php code and make it compatible

Remaining tasks

Merge PR and make the new release.

Issue fork tmgmt-3534923

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nehajyoti created an issue. See original summary.

nehajyoti opened merge request !118

lussoluca made their first commit to this issue’s fork.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
commented
Status: Active » Needs review

I've added the nullable type hint everywhere is needed

lisotton’s picture

lisotton commented
Status: Needs review » Reviewed & tested by the community

I applied the patch from the MR and it is working fine.
I'm marking it as RTBC.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented

I also get a similar message on the edit provider page, in case of having the ability to allow file translations for the translator.

( ! ) Deprecated: Drupal\tmgmt\Data::createFileTranslation(): Implicitly marking parameter $destination as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/tmgmt/src/Data.php on line 313

berdir made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Category: Support request » Bug report
Status: Reviewed & tested by the community » Fixed

All the actual fixes already happened elsewhere, but was a clean automated rebase and updates some docs the other issue didn't, so merging this as well. Merging.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • berdir committed af24ccc5 on 8.x-1.x authored by nehajyoti 
    fix: #3534923 PHP 8.4 nullable is deprecated warning

By: nehajyoti
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.