Problem/Motivation

Module is not compatible with php 8.4 and throwing warning on drush cr.

Steps to reproduce

PHP Deprecated: Drupal\layout_library\Plugin\SectionStorage\Library::access(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/docroot/modules/contrib/layout_library/src/Plugin/SectionStorage/Library.php on line 254

Proposed resolution

Fix php code and make it compatible

Remaining tasks

Merge code to main branch and make the release.

Issue fork layout_library-3534884

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nehajyoti created an issue. See original summary.

nehajyoti opened merge request !18

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Reviewed & tested by the community

Looks good!

  • larowlan committed 53f05c8a on 8.x-1.x 
    [#3534884] feat: PHP 8.4 compatibility issue

By: nehajyoti
By: plach

larowlan closed merge request !18

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Tagging 8.x-1.0-beta6, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

https://www.drupal.org/project/layout_library/releases/8.x-1.0-beta6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lucky723’s picture

lucky723 commented

Hi,
1.0-beta6 installed but phpcs still raises a warning :

FILE: /opt/drupal/web/modules/contrib/layout_library/src/Form/LayoutBuilderForm.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 54 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $section_storage.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Thanks.

rajab natshah’s picture

rajab natshah
he/him
commented

Follow up issue
#3562479: PHP 8.4 - Implicit nullable SectionStorageInterface parameter