See CI pipelines.

Issue fork editor_advanced_link-3534704

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vladimiraus created an issue. See original summary.

vladimiraus opened merge request !38

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Active » Needs work
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Assigned: Unassigned » duaelfr

I'm on it in 2.2.x branch then I'll reproduce in 2.3.x

duaelfr opened merge request !39

  • duaelfr committed 1d8ffebb on 2.2.x 
    [#3534704] fix: Fix CI issues and unit tests

By: duaelfr
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Assigned: duaelfr » Unassigned

2.2.x is green! Now let's fix 2.3.x... but another day for me ;)

duaelfr opened merge request !42

vladimiraus changed the visibility of the branch 3534704-fix-ci-issues to hidden.

  • duaelfr committed 359342ad on 2.3.x 
    [#3534704] fix: Fix CI issues and unit tests
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs work » Fixed

Finally! To be released in 2.3.2

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

cboyden’s picture

cboyden commented

This update added the JS eval function to the built script. Was that intentional? It's going to completely break CKEditor for any site that's using a Content Security Policy that prevents unsafe-eval in script-src. See commit https://git.drupalcode.org/issue/editor_advanced_link-3534704/-/commit/e... in the file js/build/editorAdvancedLink.js.

duaelfr closed merge request !38

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.