Problem/Motivation

The module has PHP 8.4 deprecation in the form of "Implicitly nullable via default value null" - https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

This produces deprecation warnings from PHP.

Steps to reproduce

Install Drupal 11+ and the 1.0.0-beta5 version of the feeds_ex module running on PHP 8.4 and observe the deprecation warnings.

Proposed resolution

See attached patch.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
ot-php8.4-fix-implicit-nullable-deprecation.patch867 bytesflemming.fridthjof

Issue fork feeds_ex-3533908

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

flemming.fridthjof created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: -PHP 8.4 deprecation +PHP 8.4
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Reviewed & tested by the community

looks good, thanks!

megachriz made their first commit to this issue’s fork.

megachriz opened merge request !58

  • megachriz committed 0675f7d4 on 8.x-1.x 
    Issue #3533908 by megachriz, flemming.fridthjof, klausi: (PHP 8.4) Fixed...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch! I turned it into a MR so tests can run. I also fixed a few other PHP 8.4 related issues that were reported by PHPStan.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.