Steps to reproduce

Install Drupal 11+ and the 3.30 version of the ds module running on PHP 8.4 and observe the deprecation warnings.

Proposed resolution

See attached patch.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
ot-php8.4-fix-implicit-nullable-deprecation.patch590 bytesflemming.fridthjof

Issue fork ds-3533907

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

flemming.fridthjof created an issue. See original summary.

abhishek_gupta1 made their first commit to this issue’s fork.

abhishek_gupta1 opened merge request !48

abhishek_gupta1’s picture

abhishek_gupta1 commented
Status: Active » Needs review

@aspilicious, I have applied above patch and followed step to reproduce, patch is working well for me , Also I have created MR for easy to merge. please review it once.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: -PHP 8.4 deprecation +PHP 8.4
dhruv.mittal’s picture

dhruv.mittal commented

Reviewing it

dhruv.mittal’s picture

dhruv.mittal commented
Status: Needs review » Reviewed & tested by the community

Changes looks good to me, so moving it to RTBC

rajab natshah’s picture

rajab natshah
he/him
commented

RTBC+1
Thank you :)
Tested with PHP 8.4

swentel’s picture

swentel commented

Hmm, for some reason, the build fails and the merge doesn't work, not sure why though (same on #3561351: Twig field, media name and block title schema missing), will try to figure out later this week.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 8.x-3.30 » 8.x-3.x-dev

The failure is not caused by this patch.

The Composer failure is because the "previous major" has PHP 8.1, which is too old for ds dependencies. This can probably be fixed by switching the devel version constraint to ^5. I have included this fix in #3333814: Fix the issues reported by phpcs.

swentel’s picture

swentel commented
Status: Reviewed & tested by the community » Fixed

Hmm, the fix was also included in #3333814: Fix the issues reported by phpcs, oh well .. :)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

swentel’s picture

swentel commented
Status: Fixed » Closed (fixed)