Problem/Motivation

1. https://git.drupalcode.org/project/radix/-/blob/6.0.x/components/navbar/... hardcodes the English phrase "Toggle navigation", we should use |trans or similar.
2. The navbar_toggler on same navbar.twig is always present. Even when site does does not have navigation. If one wants to override/remove it, the subtheme needs to copy the page, page-navigation and navbar components directories. A lot of code to repository just to remove a single button.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

sokru created an issue. See original summary.

doxigo’s picture

doxigo commented
Status: Active » Fixed

Thanks for the issue. I fixed item 1 and pushed it to the dev. For item 2, it seems rather too complex to fix a use case that barely happens (e.g., websites not having navigation), and if that's the case, we can just achieve that by a lot of copying.

That aside if we are to do Item 2, we should check if there are any blocks or content within the right or left block in the navigation, which is just too much complexity for a simple fix, for that I'm gonna set the second item to "Not going to fix" for now.

Feel free to suggest an easy solution/MR if you have something in mind.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.