Overview

In #3515646: Add automated <img srcset> generation we added a xb_parametrized_width image style that auto-converts to various widths.
In that issue we hard-coded the widths - but we should be able to make that stored/configurable in third-party settings in the image style.

Proposed resolution

Move away from hard-coded list to using TPS.

User interface changes

Comments

larowlan created an issue. See original summary.

wim leers credited lauriii.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Store allowed widths for xb_parametrized_width in third party settings » [PP-1] Store allowed widths for xb_parametrized_width in third-party settings OR a separate simple config

FYI let's include here the discussion @lauriii started at https://git.drupalcode.org/project/experience_builder/-/merge_requests/9..., where he seems to be leaning towards using simple config 🙏

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

And for the sake of expediency and landing working things, we may broaden the scope here to include doing ParametrizedImageStyle extends ImageStyle, per @larowlan at https://git.drupalcode.org/project/experience_builder/-/merge_requests/9....

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Store allowed widths for xb_parametrized_width in third-party settings OR a separate simple config » Store allowed widths for xb_parametrized_width in third-party settings OR a separate simple config
Status: Postponed » Active

#3515646: Add automated <img srcset> generation is in! 🚢

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Parent issue: » #3515646: Add automated <img srcset> generation
Related issues: +#3532718: Improve the front-end DX of `<img srcset>`

Project: Experience Builder » Drupal Canvas
Version: 0.x-dev » 1.x-dev

Experience Builder has been renamed to Drupal Canvas in preparation for its beta release. You can now track issues on the new project page.