Problem/Motivation

Baseline is out of sync. Generating the baseline when rebasing MRs leads to unrelated changes. Best to fix it here separately.

Steps to reproduce

./vendor/bin/phpstan analyse -c core/phpstan.neon.dist --generate-baseline=core/.phpstan-baseline.php

Proposed resolution

./vendor/bin/phpstan analyse -c core/phpstan.neon.dist --generate-baseline=core/.phpstan-baseline.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3533300

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !12556

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community
xjm’s picture

xjm
she/her
Primary language English
commented

I have begun the process of committing this locally to 11.x.

  • xjm committed 8d2a1436 on 11.x 
    Issue #3533300 by mstrelan: PHPStan baseline is out of sync
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Assuming this should be committed to 11.2.x as well? It applies cleanly.

  • xjm committed 827b9f4d on 11.2.x 
    Issue #3533300 by mstrelan, xjm: PHPStan baseline is out of sync
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Patch (to be ported) » Fixed

A full 11.2.x scan ran fine and we usually keep 11.x and 11.2.x in sync, so I went ahead and backported it as a separate commit (never a cherry-pick). Please reopen if this was in error.

mstrelan’s picture

mstrelan commented

Yep that looks good. I checked 10.6.x as well and that one was fine.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mstrelan closed merge request !12556