Problem/Motivation

ImagemagickExecManager has a hardcoded time limit of 60 seconds. While 60 second is already quite long, there are situations where it does not suffice.

For example, if you have (legacy) project with images that are way too big (dimensions and or filesize, you could downsize them using the image_resize module, but you are likely to still hit the duration limit.

Steps to reproduce

Proposed resolution

There are many ways to make this configurable.

Since the default value does make sense for 99% projects , I've opted to use Drupal\Core\Site\Settings for my case.
This makes it a bit more 'difficult' to add an override, compared to providing a config field for example.

Regardless of the solution, this should be offered as a 'use at your own risk' option.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

andreasderijcke created an issue. See original summary.

andreasderijcke’s picture

Assigned: andreasderijcke » Unassigned
Status: Active » Needs review
mondrake’s picture

Status: Needs review » Needs work

Thanks, this seems reasonable. Would you mind adding a note in the README to explain this?

andreasderijcke’s picture

Status: Needs work » Needs review

Subsection added to the install instructions in the README.

Hope this is clear enough, without diving too much in the potential risks, which all depend on the setup, project etc etc anyway.

mondrake’s picture

mondrake’s picture

mondrake’s picture

Committed after some minor changes. Thanks!

mondrake’s picture

Status: Needs review » Fixed
mondrake’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.