Problem/Motivation

When searching via the admin toolbar search field, if there are no results, nothing happens and there is no evidence that a search was performed. Without doing another search, it's not possible to tell whether there are no results or if something is not working. It may be nice to have a simple "No results found" message appear for cases where there are no matches.

Steps to reproduce

Do a search for something with no results and see that nothing happens.

Proposed resolution

Include a "No results found" message when no results are found to let user know that a search was actually performed.

CommentFileSizeAuthor
#4 Before MR.png97.13 KBkanchan bhogade
#4 After MR.png98.81 KBkanchan bhogade

Issue fork admin_toolbar-3532958

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisla created an issue. See original summary.

chrisla opened merge request !164

chrisla’s picture

chrisla commented
Status: Active » Needs review

I believe my submitted MR adds a usable "no results" option to the search tool that is also not clickable as a link. I am very happy to get feedback or updates to the code submitted.

kanchan bhogade’s picture

kanchan bhogade commented
StatusFileSize
new After MR.png98.81 KB
new Before MR.png97.13 KB

Hi
Tested MR 164 on Drupal 11.x
Applied MR successfully...

The "No results found" message when no results are found is displayed.

Attaching screenshot for reference

dydave made their first commit to this issue’s fork.

dydave’s picture

dydave commented
Version: 3.6.1 » 3.x-dev
Status: Needs review » Active

The merge request in this issue is now outdated.... given all the changes to the admin_toolbar_search.js in the last 3.6.3 release.

I've started working on the updated MR, but need a bit more time to refine user interactions in the JS....
I'm probably going to have to ask for a bit of help and review from my colleagues more specialized in JS and CSS (Front-end developers), so it's going to take a bit more time ...

Moving back to Active and for the dev branch.... coming back soon to this issue 👌

In any case, any feedback, suggestions, opinions or recommendations for this feature would be greatly appreciated.
Thanks in advance!