Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Overview
See https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
🤔 This is now (thanks to the removal of ::validatePageRegion() 🎉) 99% identical to the elseif ($entity instanceof XbHttpApiEligibleConfigEntityInterfaced) below — the only difference is the enforceIsNew(FALSE) — do we still need that? 🤔
Proposed resolution
Simplify if possible
User interface changes
Issue fork experience_builder-3532495
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
larowlanComment #4
larowlanComment #5
penyaskitoComment #6
penyaskitoGlad I didn't add elseif in the suggestion, nice branch name 🤣
Comment #7
larowlanMakes sense, better to be safe than sorry - thanks
Comment #8
penyaskitoComment #9
wim leersThere's a bit I don't understand yet 🙈
Comment #10
penyaskitoI don't feel that strongly, though, but a) there's no UI for creating regions; b) those are created when they are enabled for the theme in its settings, so feels safer to ensure they can't be created.
Comment #11
wim leersIt's not that I feel strongly, it's that I don't understand why
PageRegionis special-cased compared to all others. Because … all auto-saves are for updates to content & config entities only? IOW: it's impossible to create.Looks like the
enforceIsNew(FALSE)was introduced in #3494114: Implement auto-save of the page template config entity. Will figure out which commit and why.P.S.: only now see the branch name 🤣🤣🤣🤣🤣🤣🤣👏
Comment #12
wim leersCommit found: by @larowlan: https://git.drupalcode.org/project/experience_builder/-/merge_requests/4...
Comment #13
wim leersTried to generalize: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
Comment #14
wim leersThat worked :)
@penyaskito: Do you agree with the tweak I made? If so: go ahead and merge! If not: what am I missing? 😄
Comment #15
penyaskitoShip it!
Comment #16
penyaskitoI can't merge 😉
Comment #18
wim leers@penyaskito and I paired to debug why he can't merge. Even after granting him all the d.o permissions and loosening GitLab settings, he still can't merge, whereas he really should be able to. Either GitLab is broken or d.o's integration with it 😬
Merged for him! 🚀