Overview
:thinking: Why `ComponentTreeItem` and not just `ComponentInputs`? This means that _more_ than just the inputs can be modified by a `ComponentSource` plugin, which I think is a huge risk when we make this a public API.
IMHO this should be changed to something like:
```suggestion:-9+0
public function optimizeExplicitInput(array $inputValues): void;
```
which removes that risk entirely. Note that `::getDefaultExplicitInput()` already returns such an array, and `::validateComponentInput()` already accepts such an array. So it seems more consistent, too.
Won't block this commit on it though, because `ComponentSourceInterface` won't be a public API until 1.0. :thumbsup:
— https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
public function preSaveItem(ComponentTreeItem $item): void;
public function optimizeExplicitInput(array $inputValues): voi
Proposed resolution
User interface changes
Issue fork experience_builder-3532485
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
larowlanComment #6
wim leersComment #7
wim leersOops, pasted comment in the wrong
<textarea>🤣 Moved to #3529622-39: Make auto-save manager only support passing and returning entity objects, remove support for arbitrary data, use deterministic hashing to ensure entries are actually updates…Comment #8
wim leersComment #10
wim leersThanks!