Problem/Motivation

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/node/...

This is a procedural function in node.module that was previously used by statistics and forum modules. It is no longer used by Drupal core. It also has a pretty unique signature in that it takes a database result object, which wouldn't be really that useful.

Proposed resolution

Deprecate the function without replacement.

Statistics module has already done this https://git.drupalcode.org/project/statistics/-/commit/f583d9755acd97c5f...

Forum module will need similar (although much simpler) treatment in https://git.drupalcode.org/project/forum/-/blob/1.x/src/Plugin/Block/For...

The remaining usages of the function all look to be Drupal 7 modules https://git.drupalcode.org/search?group_id=2&repository_ref=11.x&scope=b...

Remaining tasks

Deprecate it

API changes

node_title_list is deprecated

Issue fork drupal-3531953

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley’s picture

acbramley commented
Related issues: +#3531954: Replace usage of node_title_list

virag.jain made their first commit to this issue’s fork.

virag.jain’s picture

virag.jain commented
Assigned: Unassigned » virag.jain

Working on it.

virag.jain opened merge request !12452

virag.jain’s picture

virag.jain commented
Assigned: virag.jain » Unassigned
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Should be deprecated for 11.3

acbramley’s picture

acbramley commented
Status: Needs work » Needs review
acbramley’s picture

acbramley commented
Parent issue: » #3532197: [meta] Deprecate node.module functions
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks! And the CR updates look great. Seems like a good deprecation.

catch closed merge request !12452

  • catch committed b0515145 on 11.x 
    Issue #3531953 by virag.jain, acbramley, smustgrave: Deprecate...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Just for fun I ran git log -S node_title_list

This function was added in 2002 with more or less the same signature - git show a6c8b10d8e07075f2bba for the details.

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.