Problem/motivation

This is an issue that sounds similar to this one: https://www.drupal.org/project/linkit/issues/3522476

Steps to reproduce

  1. Drupal Core 10.5, PHP 8.2.28, Linkit 6.1.6
  2. Either editing an existing link or inserting a new link using CKEditor
  3. The autocomplete list can show up but the "Update" or "Insert" button has no effect when clicking.

Proposed resolution

Need a fix to the module's 6.x version to be compatible with v45 of CKEditor 5.

Comments

agnesliu created an issue. See original summary.

mark_fullmer’s picture

Title: Can't Insert or Update Link after Upgrading to Drupal Core 10.5 » 6.x branch: Can't Insert or Update Link after Upgrading to Drupal Core 10.5
mark_fullmer’s picture

Need a fix to the module's 6.1.x version to be compatible with v45 of CKEditor 5.

It would be preferable to update to the 7.0.x release cycle. As far as I know, there shouldn't be any incompatibilities between Drupal 10.1 and above on that branch.

mark_fullmer’s picture

Title: 6.x branch: Can't Insert or Update Link after Upgrading to Drupal Core 10.5 » 6.1.x branch: Can't Insert or Update Link after Upgrading to Drupal Core 10.5
agnesliu’s picture

Upgraded to the 7.0.5 version and there is no issue so far. Thank you!

mariem’s picture

I was also experiencing the same issue after upgrading to core 10.5 and using linkit 6.1.6. I updated linkit to 7.0.5 and I can now edit and insert links as expected.

digitaltodd’s picture

FYI - this issue was happening with 7.0.4 too, updating to 7.0.5 works

fl-49’s picture

I have updated to core 10.5, which includes the CKE5 update to v45. And I've updated Linkit to 7.0.5. I still experience an error when adding or editing a link. In console, I see:
ckeditor5-dll.js?v=45.2.0:5 Uncaught CKEditorError: Cannot read properties of undefined (reading '_items')
I am able to add a link. And when I edit an existing link I can enter a link and save it. But when I edit an existing link it does not initially show the link that was there. I can only enter a new link.
Also, I have Linkit configured to add media links. But that is not working at all. The url field only accepts hard links.
I'll write again if I figure out a suggested solution.

Actually, this looks like an error with Editor Advanced Link. Apologies for posting it here.

peterwcm’s picture

We've tested our sites running Drupal 10.5 with Linkit 7.0.5, and encountered the following issue: when clicking the Linkit button, a console error is thrown. As a result, the autocomplete functionality does not work, and no suggestions are displayed. However, link HTML is still created when a full URL is manually entered.

Similar to the comment above, our issue might be more related to the Editor Advanced Link plugin

ckeditor5-dll.js?v=45.2.0:5 Uncaught CKEditorError: Cannot read properties of undefined (reading 'viewUid')
mark_fullmer’s picture

Similar to the comment above, our issue might be more related to the Editor Advanced Link plugin

Thanks for the update. I'll leave this issue open for now for visibility, but it does seem that at this point, all reports of problems are coming from people who are using Editor Advanced Link. Folks should head to #3531194: D11.2 / D10.5: Uncaught CKEditorError: Cannot read properties of undefined (reading 'viewUid') to follow progress there.

kasey_mk’s picture

I'm having this problem on 7.0.4 and 7.0.5, with Drupal 10.5 and without Editor Advanced Link, but removing the patch for Show URL alias after autocomplete selection instead of internal route (e.g., /node/123) makes the error go away.

I really like that patch, though. Plus the one for Display node title (a text) in by default when creating link in ckeditor5 which no longer applies. I'll take a look to see if I can re-roll either or both on the new code.

kasey_mk’s picture

After a week and a new round of updates, things seem to be working again. Thanks to all who contributed!

agnesliu’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.