Problem/Motivation

10.5 and 11.2 include an update of CKEditor to v45 which has breaking changes that impact this module.

All CKEditor 5 icons are now available in the @ckeditor/ckeditor5-icons package.

https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-45....

Steps to reproduce

Install on 11.2 or 10.5

Proposed resolution

Update icon import path - see https://git.drupalcode.org/project/drupal/-/blame/11.x/core/modules/cked... and https://git.drupalcode.org/project/drupal/-/blame/11.x/core/modules/cked... as examples.
Update version compatibility

Remaining tasks

Implement

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#3 file.png24.3 KBericgsmith
#5 composer.jpeg154.33 KBricharddavies
#6 edit_media_modal-3531671-drupal_compatibility-6.patch134.35 KBmortona2k

Issue fork edit_media_modal-3531671

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ericgsmith created an issue. See original summary.

ericgsmith opened merge request !5

ericgsmith’s picture

ericgsmith commented
Status: Active » Needs review
StatusFileSize
new file.png24.3 KB

Alright, got that pesky button working.

Bit of a shame the core version requirement has to be bumped - maybe there is a clever way to do this as a shim to keep support for both. Either way, this should be working now.

ericgsmith’s picture

ericgsmith commented
Priority: Normal » Critical
richarddavies’s picture

richarddavies commented
StatusFileSize
new composer.jpeg154.33 KB

I can't get this patch to apply. Am I doing something wrong?

screenshot of composer error

mortona2k’s picture

mortona2k commented
StatusFileSize
new edit_media_modal-3531671-drupal_compatibility-6.patch134.35 KB

The problem is that the Drupal.org packaging script info is in the actual repo file (should only be added when installed by composer).

https://git.drupalcode.org/project/edit_media_modal/-/blob/2.x/edit_medi...

That needs to be removed separately, it's conflicting with this MR.

Here is a patch that doesn't have that change.

richarddavies’s picture

richarddavies commented

Thanks, patch in #6 works for me.

ericgsmith’s picture

ericgsmith commented

Yeah, unrelated to this MR but as I was changing the info file I saw and removed it on instinct - it would be good to remove it separately.

I'll rebase this MR and drop that commit.

Re patch - you can also reference just the commit that has the compiled plugin instead of the whole MR - https://git.drupalcode.org/issue/edit_media_modal-3531671/-/commit/12a9b...

blade_ukraine’s picture

blade_ukraine commented
Status: Needs review » Fixed

Thanks. Here is a new release https://www.drupal.org/project/edit_media_modal/releases/2.0.2

blade_ukraine’s picture

blade_ukraine commented
Status: Fixed » Closed (fixed)