The settings for the theme appears also in the global theme settings, and the settings of other themes.

This happens because seven_form_system_theme_settings_alter() has been added to the seven.theme file, not the theme-settings.php file.

Issue fork seven-3531148

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

avpaderno created an issue. See original summary.

divyansh.gupta’s picture

divyansh.gupta commented
Assigned: Unassigned » divyansh.gupta

Working on this

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: divyansh.gupta » avpaderno

avpaderno changed the visibility of the branch 3531148-the-settings-for to hidden.

avpaderno opened merge request !159

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review

  • avpaderno committed 66f37fe0 on 2.0.x 
    Issue #3531148: The settings for the Seven theme appear between the...

  • avpaderno committed 8f21f564 on 1.0.x 
    Issue #3531148: The settings for the Seven theme appear between the...
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 2.0.x-dev » 1.0.x-dev
Status: Needs review » Fixed
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: avpaderno » Unassigned
divyansh.gupta’s picture

divyansh.gupta commented

Hi @avpaderno,
I had previously assigned this issue to myself and mentioned that I was working on it. I was able to resolve the issue locally, but ran into a Git-related problem that prevented me from pushing the patch in time.
I noticed that you reassigned and committed a fix in the meantime. I appreciate the quick resolution and fully respect the contribution.
Just wanted to note this for transparency, as the general guideline encourages coordination before reassigning issues that are actively being worked on. Looking forward to continued collaboration—thanks again!

divyansh.gupta’s picture

divyansh.gupta commented

Hi @avpaderno, just a gentle follow-up on my earlier comment above. Appreciate your time, thanks!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@divyansh.gupta The issue required to move a function from a file to another; the function to move, where the function was defined, and where the function needed to be moved is described in the issue summary. It does not take four hours to make a merge request.

If you had any problem, you should have posted a comment saying you were going to work on this later. Assigning an issue to yourself does not mean the issue can be kept "suspended" for undefined time.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.