Problem/Motivation

Now that gitlab has nice runnable pipelines, we should utilize these and fix up the gitlab ci.

Fix up phpcs warnings in pipeline

CommentFileSizeAuthor
#7 phpcs-done.png47.27 KBtechmantejas
#6 gitlab-ci.png45.78 KBtechmantejas

Issue fork eu_cookie_compliance-3528293

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

atowl created an issue. See original summary.

atowl’s picture

atowl commented
Issue tags: +phpcs, +good first issue

techmantejas made their first commit to this issue’s fork.

techmantejas opened merge request !162

techmantejas’s picture

techmantejas commented
Assigned: Unassigned » techmantejas

Added phpcs in the gitlab-cli.yml now working on fixing the issues here.

techmantejas’s picture

techmantejas commented
StatusFileSize
new gitlab-ci.png45.78 KB

Hi maintainers I have added this template, please review it

gitlab ci

techmantejas’s picture

techmantejas commented
Assigned: techmantejas » Unassigned
Status: Active » Needs review
StatusFileSize
new phpcs-done.png47.27 KB

phpcs completed

PHPCS is done, Php unit though is throwing an error.

atowl’s picture

atowl commented

Thanks @techmantejas

i'll get onto review this shortly.

I was thinking we could merge all these into the gitlab-resolve branch, so that #3408084 would resolve?

techmantejas’s picture

techmantejas commented

Yup, in this MR:-

  1. Updated gitlab-ci.yml to have the template for composer phpcs phpstan phpunit
  2. Fixed phpcs issues that were occuring in file

So you can consider the phpcs issue fixes in the src files of the module, that should solve things from this child issue.

atowl changed the visibility of the branch 8.x-1.x to hidden.

atowl changed the visibility of the branch 8.x-1.x to active.

atowl’s picture

atowl commented
Status: Needs review » Fixed

Thanks - looks like it's now passing phpcs!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.