Problem/Motivation

> Use clean URL's

This should say 'URLs' without the apostrophe.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 After_screenshot.png46.94 KBvinodhini.e
#7 After_Apply_Screenshot.png18.18 KBAnonymous (not verified)
#7 Before_Screenshot.png13.51 KBAnonymous (not verified)
#4 3527869_without_the_apostrophe.png42.98 KBdanrod

Issue fork search_api_page-3527869

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

danrod’s picture

danrod
Location Ottawa
commented
Assigned: Unassigned » danrod

danrod opened merge request !14

danrod’s picture

danrod
Location Ottawa
commented
StatusFileSize
new 3527869_without_the_apostrophe.png42.98 KB

I created a MR for this, please review: https://git.drupalcode.org/project/search_api_page/-/merge_requests/14

Screenshot attached:

Screenshot of the Search API Form API without the extra '

danrod’s picture

danrod
Location Ottawa
commented
Status: Active » Needs review
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Perfect, thanks!

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new Before_Screenshot.png13.51 KB
new After_Apply_Screenshot.png18.18 KB

Hi @danrod,
I have reviewed and applied the changes, and everything is working fine.
Here before and after screenshots attached.
Thank you!

vinodhini.e’s picture

vinodhini.e commented
StatusFileSize
new After_screenshot.png46.94 KB

Hi @danrod,

Reviewed and applied changes and working fine. Thanks.

vinodhini.e’s picture

vinodhini.e commented
fjgarlin’s picture

fjgarlin commented

Hi @vinojbi and @vinodhini.e. Note that the issue was already RTBC in #6 the day before you commented on this issue. Also the screenshots provided don't add anything new, as there was one already in #4 with the same changes.

@vinodhini.e, adding your company to both organization and customer won't have any double impact on credits. In fact, doing so might be seen as wanting to game the contribution system to try to obtain double credit.

I recommend you both to go through this page https://www.drupal.org/community/contributor-guide, see the links in it (specially "Issue Queue Etiquette") and even the two videos at the bottom. These resources will help you improve the quality of your contributions, making sure that the time that you spend is meaningful and impactul for you and the community.

vinodhini.e’s picture

vinodhini.e commented

Hi @fjgarlin,
" @vinodhini.e, adding your company to both organization and customer won't have any double impact on credits. In fact, doing so might be seen as wanting to game the contribution system to try to obtain double credit." -- Thanks for pointing that out. I had forgotten to add the organization in my initial comment, so I updated it — there was no intention to game the system.

Thank you for the clarification. I appreciate your guidance and will make sure to follow the contributor guide and issue queue etiquette going forward.

fjgarlin’s picture

fjgarlin commented

Thanks for the acknowledgment @vinodhini.e

danrod’s picture

danrod
Location Ottawa
commented
Assigned: danrod » Unassigned

karlshea made their first commit to this issue’s fork.

  • karlshea committed 1ff60d6c on 8.x-1.x authored by danrod 
    feat: #3527869 typo in form

By: joachim
By: danrod
karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.